Toolbar positioning breaks on Meta.SO and SO redesign

Question

Toolbar positioning breaks on Meta.SO and SO redesign

Closed this issue 10 years ago · 3 comments

AstroCB commented 10 years ago

The redesign of Meta Stack Overflow seems to have broken the positioning of the button in the toolbar as shown below:

I'm not sure what's different about the new Meta from other sites, but it's odd either way.

Answer 1 · 2015-01-16T04:30:32.000Z

The design is now live on Stack Overflow as well

Answer 2 · 2015-01-16T04:47:50.000Z

I'm still not sure what's causing this issue; @jt0dd is the one who implemented the new positioning (in 1.0, I just mimicked the stock buttons, but the styling was way off), so I'll let him look into it.

Answer 3 · 2015-02-03T04:37:14.000Z

This was a weird one to fix; I have no idea what Stack Exchange changed in the M/SO redesign, but whatever it is hasn't been applied to other sites. If it is, all we'll have to do is remove a check I provided before applying the new styling.

Mimicking the stock buttons by making the button a span enclosed in an li class="wmd-button" would prevent issues like this, but that would break a lot of the styling we have, so I'm not sure it's worth it.