AthanorLabs/atomic-swap

swapcli command to subcribe to ongoing swap

dimalinux opened this issue · 2 comments

We have a subscribeSwapStatus RPC endpoint, but never extended swapcli to be able to attach/subscribe to an ongoing swap.

I'm having second thoughts as to whether this would be a good feature without a backend architecture change. Right now we are using a channel. If 2 clients subscribe to the same swap, only one of the two clients will get each of the successive state changes. It could become a support headache if end users run swapcli make in one window and then swapcli subscribe in a different windows. I'm thinking we don't want this feature until/unless we allow multiple subscribers to the same offer ID, where every subscriber gets the updates.

I'm going to close this issue for now, based on the reason mentioned in the previous comment.