AtlasPublicPolicy/power-bi-embedded

Embedded reports’ backgrounds are not showing up since version 1.1.4

Closed this issue · 3 comments

Hi!

On version 1.1.4 and 1.1.5, the background of our embedded reports are not showing up. The last working version is 1.1.3. Is there any fix to this?

I know the plugin is funded by internal resources of Atlas Policy, so I don’t want to sound harsh or bossy.

Even though I have never developed a plugin, I have some experience with PHP and other languages. If anyone from the development team of this plugin could give at least a hint on what I could look at to see if I find the problem, I’d happily check it out.

In the meantime, I will keep looking at the plugin source code and trying to identify what is causing this issue. I thought of comparing all files from 1.1.3 (last working version) and 1.1.4 (when the bug started) to check what has changed and what could be causing this.

Thanks for this plugin, it’s very handy and besides these minor bugs, works great.

Thanks for your message! Per our message to you on WordPress: We hired a consultant to help us upgrade the plugin but that work introduced some notable problems and we haven’t been able to get resources to fix them. We’re hoping to have time to look at it next month. We welcome any contribution you might have to the plugin and appreciate your support!

Hi @npnigro! Thanks for getting back to me.

I’m glad you have plans for keeping this valuable project going on and surely will do my best to help, if I’m able to. Looking forward for your future updates, as well!

This plugin is a gem, there are literally no comparable alternatives to it and I’m pretty sure everyone that uses it agree with me. Well, you also use it by yourselves, so you know what I mean by it hehehe.

Thanks in advance! 😁

UPDATE: Hey guys, just letting you know I've probably found what is causing the bug and a quickfix.

Recapping, I was having trouble fetching the background of a report after update 1.1.4.

After further investigation, using 1.1.4, when I tried to use a "Background color" in a report through the plugin (actually, I've tried to make the background transparent using the variable models.BackgroundType.Transparent.), I've noticed on the console an error inside processReportData() on /wp-content/plugins/embed-power-bi/assets/js/powerbi-report.js, which was telling me "background must be a number" or something like that.

So it looks like there's a problem while trying to read "background" key on "embedConfiguration".

TL;DR: if you're having the same problem as me, just comment line 69 (I believe), when you create the embedConfiguration object at line 61, on file /wp-content/plugins/embed-power-bi/assets/js/powerbi-report.js:

let embedConfiguration = {
    type: reportData.embed_type,
    embedUrl: reportData.embed_url,
    tokenType: models.TokenType[reportData.token_type],
    accessToken: access_token,
    settings: {
        filterPaneEnabled: reportData.filter_pane === 'on' ? true : false,
        navContentPaneEnabled: reportData.page_navigation === 'on' ? true : false,
        // background: reportData.background !== '' ? reportData.background : models.BackgroundType.Transparent,
        localeSettings: {
            language: reportData.language,
            formatLocale: reportData.format_local,
        }
    },
};

Keep in mind that this quickfix will probably get overwritten on plugin's next update.