Load icons asynchronously?
Closed this issue · 3 comments
Is your feature request related to a problem? Please describe.
When browsing repositories with many files in them, it significantly increases the time it needs to load.
Describe the solution you'd like
Show the GitHub icons first, then load the custom icons asynchronously in the background.
Describe alternatives you've considered
Somehow preloading the icons?
Additional context
I'm not sure if it has something to do with the Firefox version of the add-on. I'll have to double-check if the performance impact is also that big in Chromium based browsers.
When browsing repositories with many files in them, it significantly increases the time it needs to load.
Could you provide an example URL of such a page?
@jkowalleck It only seems to happen when browsing from one folder to another.
For example, try visiting https://github.com/bikass/kora/tree/master/kora/actions then click on symbolic
When loading https://github.com/bikass/kora/tree/master/kora/actions/symbolic directly, it does not produce any lag for me.
Recording showing the behavior (in a clean Firefox profile):
Peek.2022-04-26.00-40.mp4
GitHub
Kora icon theme for GNU/Linux os. Contribute to bikass/kora development by creating an account on GitHub.
Kora icon theme for GNU/Linux os. Contribute to bikass/kora development by creating an account on GitHub.
Interesting, I knew about such an issue but I didn't think it was caused by the extension. I'll look into it.