large lag spikes on entering dimensional door dimension
Closed this issue · 7 comments
2023-09-13.16-30-12.mp4
No clue. You don't even have any light on you. Sorry, but i dont support such old versions anymore.
Just for reference, these are the results from a profiler:
hackRenderGlobalConcurrently is a very expensive action that is meant to run one single time when you change dimensions. Clearly it's running again and again in your case.
But this is after the global disabler button check - so just use the turn off button while in that dimension.
If you want to tinker with this by yourself, do not let me stop you:
https://github.com/AtomicStryker/atomicstrykers-minecraft-mods/tree/1.12.2/DynamicLights
If you are very lucky, "gradlew.bat build" will still work or require minimal googling and fixing.
If you are unlucky, the relevant resources wont be online anymore.
The problem is most likely this line:
https://github.com/AtomicStryker/atomicstrykers-minecraft-mods/blob/1.12.2/DynamicLights/src/main/java/atomicstryker/dynamiclights/client/DynamicLights.java#L193
Variable "world" will either be alternating between multiple dimensions or there will be something strange about it.
@AtomicStryker Thank you for the hint! Will further look into this.
Without any code changes, adding Dimensional Doors' dimension IDs to bannedDimensionIDs seems to be a valid workaround:
I:bannedDimensionIDs <
-1
684
685
686
687
688
>
Interestingly this is pre-populated with -1 for the Nether, I wonder why.
But the best solution appears to be adding Hesperus, which has code changes specifically for Dynamic Lights and it resolves this issue completely without requiring any configuration changes.