AuDigitalHealth/ci-medicare-records

ExtensionDonationDecision :: erroneous slicing on value[x]

Closed this issue · 2 comments

Prerequisites

  • I have verified the problem exists in the available content
  • I have searched open and closed issues to make sure it isn't already reported
  • I have written a descriptive issue title

The bug

Probably caused by tooling limitations at the time, but the extension includes a slice for value[x] that is not required; instead the extension can simply constrain the type.
For example, in an instance of ExtensionDonationDecision:

          "id": "Extension.value[x]",
            "path": "Extension.value[x]",
            "slicing": {
                "discriminator": [{
                    "type": "type",
                    "path": "$this"
                }],
                "ordered": false,
                "rules": "closed"
            },
            "short": "Value of extension",
            "definition": "Value of extension - may be a resource or one of a constrained set of the data types (see Extensibility in the spec for list).",
            "min": 1,
            "max": "1",
            "base": {
                "path": "Extension.value[x]",
                "min": 0,
                "max": "1"
            },
            "type": [{"code": "dateTime"}],

Suggest removing the slicing and adding a constraint on the value.type instead. This change should not have any normative impacts but it is an improvement in terms of processing requirements and implementing correct profiling practices. 

Confirmed change; no further issues found.