Automattic/newspack-plugin

Site logo is too large when using initial placeholder content

leogermani opened this issue · 4 comments

Describe the bug
At the end of the onboarding wizard, you get redirected to the Yoast page instead of the Newspack dashboard

To Reproduce
Steps to reproduce the behavior:

  1. Install Newspack on a brand new site
  2. Activate the plugin and go through the wizard
  3. Do not change any defaults
  4. After your site is initialized, check the home page
  5. See that the newspack Logo is way too large
  6. If you go to Appearance -> Customize you can fix the logo size

Expected behavior
I expected the logo to be set as small by default

I actually tested this flow a couple of times and I cant reproduce it consistently. Sometimes it works and sometimes it doesnt

This might be more of an issue with the theme than the plugin, if the size setting isn't being changed in the wizard 😬

There is an issue with the preview sometimes that I haven't totally tracked down. I haven't actually run into anything on the front end, though I wouldn't rule it out!

@leogermani just to make sure, is the issue happening on the front-end, or in the Customizer?

@laurelfulford it's on the front end.

When I go to the customizer, the logo is also big, and I can fix it by setting its size

It's an issue with the information saved in the theme_mod. It is as if this line did not run:

set_theme_mod( 'logo_size', 0 );

But as I commented before, when I try to reproduce it, it happened to me 3 or 4 times, and then it started worked as it should... so I was unable to debug it properly..

Ah, thanks @leogermani! 🤔 Very odd! I haven't run into this myself yet, but I'll keep an eye out any time I set up a site!