Automattic/regenerate-thumbnails

Verify useful error messages for invalid images

Closed this issue · 4 comments

Viper007Bond commented

Yeah, already properly handled. Verified by renaming a PHP file to .jpg and then uploading it. Trying to run the plugin on it displays useful error messages.

firefox_2017-11-14_19-34-05

firefox_2017-11-14_19-35-18

archon810 commented

Sorry, but this wasn't the case for me, as I mentioned. The error message was about an unknown error. The file was not PHP, but a valid image file (webp), which isn't handled by WP. Get a WebP file and rename it as PNG to reproduce.

Viper007Bond commented

Right, but you're using the latest stable version (v2.x) and my screenshots are from the upcoming v3.x where a useful error message is displayed. :)

archon810 commented

Ah, OK, I thought you were saying it was already handled by existing code.

  • 👍1