Axelrod-Python/Axelrod

Run isort utility on all files

gaffney2010 opened this issue · 6 comments

gaffney2010 commented

Similar to #1312. The contribution guidelines should say this should be run on every file. We can run on all files and possibly add a check.

drvinceknight commented

There might be a slight problem that arises, in my experience on other projects checking isort and black sometimes don't seem to agree (if I recall). If it works though I'm 100% in favour (and will need to go back to my other projects...)! (If we have to choose I think we go with black).

akash-suresh commented

Hey! Can I pick this up? 😄

I have used isort, in one of my earlier projects. And this seems like a fairly simple task to get acquainted with the codebase.

drvinceknight commented

Please do 👍

akash-suresh commented

Hey @drvinceknight, I tried running the unit-test suite to make sure, its setup properly. A few of the test cases are failing. I am using Python 3.8.

drvinceknight commented

Yeah there are a couple of tests that don't pass yet on py3.8 (#1315). If you setup a virtual environment with py3.7 you should be fine.

akash-suresh commented

Oh alright. Thanks for the clarification. 👍

  • 👍1