Azure-Samples/service-fabric-dotnet-getting-started

Sample doesn't build from MSBuild

dfederm opened this issue · 2 comments

dfederm commented

Repro:

E:\service-fabric-dotnet-getting-started\src\GettingStartedApplication\GettingStartedApplication> msbuild /t:Package

Error:

"E:\service-fabric-dotnet-getting-started\src\GettingStartedApplication\GettingStartedApplication\GettingStartedApplication.sfproj" (Package target) (1) ->
"E:\service-fabric-dotnet-getting-started\src\GettingStartedApplication\ActorBackendService\ActorBackendService.csproj" (default target) (2:2) ->
"E:\service-fabric-dotnet-getting-started\src\GettingStartedApplication\ActorBackendService.Interfaces\ActorBackendService.Interfaces.csproj" (default target) (6:2) ->
(_CheckForInvalidConfigurationAndPlatform target) ->
  C:\Program Files (x86)\Microsoft Visual Studio\Preview\Enterprise\MSBuild\15.0\bin\Microsoft.Common.CurrentVersion.targets(780,5): error : The OutputPath property is not set for project 'ActorBacke
ndService.Interfaces.csproj'.  Please check to make sure that you have specified a valid combination of Configuration and Platform for this project.  Configuration='Debug'  Platform='AnyCPU'.  You ma
y be seeing this message because you are trying to build a project without a solution file, and have specified a non-default Configuration or Platform that doesn't exist for this project. [E:\service
-fabric-dotnet-getting-started\src\GettingStartedApplication\ActorBackendService.Interfaces\ActorBackendService.Interfaces.csproj]


"E:\service-fabric-dotnet-getting-started\src\GettingStartedApplication\GettingStartedApplication\GettingStartedApplication.sfproj" (Package target) (1) ->
"E:\service-fabric-dotnet-getting-started\src\GettingStartedApplication\StatelessBackendService\StatelessBackendService.csproj" (default target) (4:2) ->
"E:\service-fabric-dotnet-getting-started\src\GettingStartedApplication\StatelessBackendService.Interfaces\StatelessBackendService.Interfaces.csproj" (default target) (7:2) ->
  C:\Program Files (x86)\Microsoft Visual Studio\Preview\Enterprise\MSBuild\15.0\bin\Microsoft.Common.CurrentVersion.targets(780,5): error : The OutputPath property is not set for project 'StatelessB
ackendService.Interfaces.csproj'.  Please check to make sure that you have specified a valid combination of Configuration and Platform for this project.  Configuration='Debug'  Platform='AnyCPU'.  Yo
u may be seeing this message because you are trying to build a project without a solution file, and have specified a non-default Configuration or Platform that doesn't exist for this project. [E:\ser
vice-fabric-dotnet-getting-started\src\GettingStartedApplication\StatelessBackendService.Interfaces\StatelessBackendService.Interfaces.csproj]

    0 Warning(s)
    2 Error(s)

Time Elapsed 00:00:02.23

Looking at those projects, they only define OutputPath for Platform x64, but AnyCPU is the Platform being used.

dfederm commented

I was able to mitigate by adding <Platform>x64</Platform> to WebService.csproj.

Although both interfaces projects also have incorrect defaults for Platform. They default to AnyCPU despite only having config for x64. The csproj's need to be updated for those as well.

For the WebService.csproj issue, it looks like GetServiceProjectReferences is trying to read the platform and finds "AnyCPU" by default so sets it explicitly to that when building it. Then all recursively references also build with that platform, which isn't the intent.

As an aside, GetServiceProjectReferences seems to be loading up the projects using the MSBuild API, which is just terrible for perf. You're already in the context of MSBuild, so just pass the information along rather than spinning up yet another MSBuild evaluation per referenced project.