Azure/ALZ-Bicep

Logging module includes property `sku` for sentinel

picccard opened this issue · 3 comments

picccard commented

Logging module template includes a non-allowed "sku" property for microsoft.operationsmanagement/solutions

Template-spec for the resource does not include the sku-property, I'm guessing the RP modified the existing template-spec-api to remove the sku-property sometime after the simplified-pricing(Unified) was introduced.

https://learn.microsoft.com/en-gb/azure/templates/microsoft.operationsmanagement/solutions?pivots=deployment-language-bicep

image

oZakari commented

Hi @picccard, that makes sense to me as well. @jtracey93 is this something we can remove or was this supporting some edge case that it needs to stay in?

jtracey93 commented

This was done way back in #582 relating to https://learn.microsoft.com/azure/sentinel/enroll-simplified-pricing-tier?tabs=microsoft-sentinel#change-pricing-tier-to-simplified and i introduced it in a non-breaking way.

The API version it was pinned to should still support the deployment and bicep linter may be incorrectly flagging this, have you deployed it @picccard to confirm?

Happy for it to be removed if not needed, but to my understanding it should be fine to leave to cover customers using the classic pricing tier

  • 👍1
oZakari commented

Just tested it, and the classic pricing model still works with this API version so will leave it in.