Azure/ARO-RP

TestBackendTry unit test flake

jim-minter opened this issue · 1 comments

@hawkowl, I saw the following unit test flake - there's not much to go on, but can you see if you can work it out?

=== RUN   TestBackendTry
=== RUN   TestBackendTry/StateCreating_success_that_sets_an_InstallPhase_stays_it_in_Creating
    openshiftcluster_test.go:330: slice[0].OpenShiftCluster.Properties.Install: <nil pointer> != api.Install
=== RUN   TestBackendTry/StateCreating_success_without_an_InstallPhase_marks_provisioning_as_succeeded
=== RUN   TestBackendTry/StateCreating_that_fails_marks_ProvisioningState_as_Failed
=== RUN   TestBackendTry/StateAdminUpdating_success_sets_the_last_ProvisioningState_and_clears_LastAdminUpdateError
=== RUN   TestBackendTry/StateAdminUpdating_run_failure_populates_LastAdminUpdateError_and_restores_previous_provisioning_state_+_failed_provisioning_state
=== RUN   TestBackendTry/StateDeleting_success_deletes_the_document
--- FAIL: TestBackendTry (0.01s)
    --- FAIL: TestBackendTry/StateCreating_success_that_sets_an_InstallPhase_stays_it_in_Creating (0.00s)
    --- PASS: TestBackendTry/StateCreating_success_without_an_InstallPhase_marks_provisioning_as_succeeded (0.00s)
    --- PASS: TestBackendTry/StateCreating_that_fails_marks_ProvisioningState_as_Failed (0.00s)
    --- PASS: TestBackendTry/StateAdminUpdating_success_sets_the_last_ProvisioningState_and_clears_LastAdminUpdateError (0.00s)
    --- PASS: TestBackendTry/StateAdminUpdating_run_failure_populates_LastAdminUpdateError_and_restores_previous_provisioning_state_+_failed_provisioning_state (0.00s)
    --- PASS: TestBackendTry/StateDeleting_success_deletes_the_document (0.00s)
FAIL
coverage: 38.8% of statements
FAIL	github.com/Azure/ARO-RP/pkg/backend	0.089s

https://msazure.visualstudio.com/AzureRedHatOpenShift/_build/results?buildId=36744197&view=logs&j=10f66467-59e5-53bc-0c8a-42cc89770de4

This happened on 7f2d32f + some irrelevant changes (#1157)