Key Vault secret reference resolution should respect startup timeout allowance
Closed this issue · 1 comments
With the introduction of time-based retries on startup, the provider now continues attempting to connect to Azure App Configuration to load the initial configuration until the startup timeout elapses, or until the connection is successful.
Currently, Key Vault secret reference resolution in the provider does not respect the configured startup timeout allowance. If Key Vault is momentarily down during startup and secret references are used in the configuration then startup will fail if the default Key Vault retry count (3) is exceeded. This will surface as a KeyVaultReferenceException.
The provider should be updated to recognize transient Key Vault errors, such as momentary unavailability and retry as long as the startup timeout allows.
The PR originally merged for this PR introduced an issue where Key Vault exceptions would trigger a failover in the provider, which can cause throttling in certain scenarios. It also didn't make sense in the context of geo-replication since the Key Vault reference would remain the same across replicas but would continue being retried. This PR is being reverted, and the original concern in this issue is being addressed by #589 to lower the impact of transient Key Vault connection errors.