Azure/Bridge-To-Kubernetes

Image name "bridgetokubernetes.azurecr.io/lpkremoteagent:1.3.4" is hardcoded, breaks in hardened environments

sleepy-manul opened this issue · 1 comments

Describe the bug
The extension assumes that the Kubernetes cluster can access the container registry bridgetokubernetes.azurecr.io, which is an absolute no-go in corporate environments. The name of the registry where the image is pulled from must therefore be configurable.

Mention the platform you are using
Visual Studio 2022 Community, Extension Version 3.2.20240123.7

To Reproduce
self-explanatory

Expected behavior
The profile for Bridge-to-Kubernetes has a configuration option to set the container registry and choose a pull secret.

Screenshots
not required

Logs:
not applicable

Desktop (please complete the following information):
not applicable

Smartphone (please complete the following information):
not applicable

Additional context
not applicable

@sleepy-manul there is an option to provide your registry as environment variable. if these variables are present as part of your environment variable it should pick your custom registry. Please let me know for further details. Thank you.

Env variables are:
BRIDGE_DEVHOSTIMAGENAME
BRIDGE_RESTORATIONJOBIMAGENAME
BRIDGE_ROUTINGMANAGERIMAGENAME

ex: export BRIDGE_DEVHOSTIMAGNAME='registryurl/tag'