Release 0.75.1 is just like 0.75.0 (did not include the GPU SKU changes)
Michael-Sinz opened this issue · 3 comments
Describe the bug
The release of aks-engine 0.75.1 was supposed to include the new A10 GPU SKU support but the build for 0.75.1 seems to have been done from the 0.75.0 tag and thus does not actually include the changes.
Steps To Reproduce
Build the template with an A10 GPU SKU pool and notice that the template still sets the A10 SKU as GPU_NODE=false
"name": "[variables('gpupoola10VMNamePrefix')]",
"properties": {
"overprovision": false,
"singlePlacementGroup": false,
"upgradePolicy": {
"mode": "Manual"
},
"virtualMachineProfile": {
"extensionProfile": {
"extensions": [
{
"name": "vmssCSE",
"properties": {
"autoUpgradeMinorVersion": true,
"protectedSettings": {
"commandToExecute": "[concat('echo $(date),$(hostname); for i in $(seq 1 1200); do grep -Fq \"EOF\" /opt/azure/containers/provision.sh && break; if [ $i -eq 1200 ]; then exit 100; else sleep 1; fi; done; ', variables('provisionScriptParametersCommon'),' USER_ASSIGNED_IDENTITY_ID=',reference(variables('userAssignedIDReference'), variables('apiVersionManagedIdentity')).clientId, ' ',' IS_VHD=true GPU_NODE=false SGX_NODE=false AUDITD_ENABLED=false /usr/bin/nohup /bin/bash -c \"/bin/bash /opt/azure/containers/provision.sh >> /var/log/azure/cluster-provision.log 2>&1\"')]"
},
"publisher": "Microsoft.Azure.Extensions",
"settings": {},
"type": "CustomScript",
"typeHandlerVersion": "2.0"
}
}
]
},
Expected behavior
GPU_NODE=true in the above section of the template
AKS Engine version
0.75.1
Additional context
Note that the build for the 0.75.1 seems to have referenced the 0.75.0 tag: https://github.com/Azure/aks-engine/actions/runs/3988699445
It seems the 0.75.1 tag was added before the changes for the new GPU SKU was in?
@jackfrancis I think the issue is that if we look at the branch 0.75.1, it does not have my change to add support for the A10 SKU. There should be this commit where we have the red arrow:
Yes, I made a mistake kicking off release automation and sourced a v0.75.1 release from the same commit as the existing v0.75.0. A v0.75.2 has been cut as a fix: