Azure/aks-periscope

Scope work: to either retire GetAPIServerFQDN function or make it less tightly coupled with storage alternative.

Closed this issue · 2 comments

Tatsinnit commented

This issue is open to get wider idea from anyone interested to share their thoughts on retiring or at least finding better alternative to the GetAPIServerFQDN function in https://github.com/Azure/aks-periscope/blob/master/pkg/utils/helper.go#L136

Why to scope work to either retire or find better alternative to de-couple?

Currently this function is only getting called from the networkoutbound collector but the other place this function gets called is from the azure-blob-exporter where we use this public FQDN as a container name.

Proposal:

  • Proposal 1 - Medium term - we should investigate the impact and what all tool will get impacted and work / strategy required in the case where we use Storage Container name as aks-periscope-<SOME_UNIQUE_CONSISTENT_VALUE> which will remove the public FQDN funct to be used for storage hence the function will no longer be helper but only the internal function for network outbound collector.

  • Proposal 2 - not required but - long term - remove this dependency and identify why network outbound collector need this, but in any case worth to investigate this.

Thanks heaps. 🙏

cc: - anyone interested + @arnaud-tincelin , @JunSun17

Tatsinnit commented

Notes: We cannot get cluster-name with in the cluster context because of this:

Thanks,

Tatsinnit commented

🙏 Thanks all for discussion, this is fixed as part of this recent release. https://github.com/Azure/aks-periscope/releases/tag/v0.5 , closing this issue.