Azure/azure-functions-durable-extension

Targeting Net8.0 (Isolated) and using Durable Functions Orchestration within an Azure Functions project causes NuGet to restore old vulnerable packages

Opened this issue · 5 comments

mikejohnstonPremierinc commented

Description

NuGet is restoring non-targeted old versions of packages for this specific azure functions project.

For example, if I add <PackageReference Include="Newtonsoft.Json" Version="13.0.3" /> to my .csproj file, NuGet should ONLY restore 13.0.3.

Instead, it is restoring 9.0.1, 10.0.1, 10.0.2, 11.0.2 13.0.1

Cause
I originally thought the cause was bug 13943. 13943 bug was first seen in the new version of the NuGet Dependency Resolver that came packaged with the new version of Visual Studio.

I implemented the workaround for 13943. The workaround is to use the legacy resolver, but my issue persisted. Old packages were still being restored.

I then downgraded Visual Studio to earlier versions, and my issue still persisted.

I posted a bug on the NuGet repository myself, as shown Here. But a developer told me that the issue is not caused by a bug within the NuGet code, but instead it is a bug within the azure functions code, as explained Here.

Specifically:

What's happening in Azure Functions apps is that the SDK is generating a .csproj on the fly in the obj folder:

<Project Sdk="Microsoft.NET.Sdk">
    <PropertyGroup>
        <TargetFramework>net6.0</TargetFramework>
        <Configuration>Release</Configuration>
        <AssemblyName>Microsoft.Azure.Functions.Worker.Extensions</AssemblyName>
        <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
    </PropertyGroup>

    <ItemGroup>
        <PackageReference Include="Microsoft.NETCore.Targets" Version="3.0.0" PrivateAssets="all" />
        <PackageReference Include="Microsoft.NET.Sdk.Functions" Version="4.3.0" />
        <PackageReference Include="Microsoft.Azure.WebJobs.Extensions.DurableTask" Version="2.13.1" />
    </ItemGroup>

    <Target Name="_VerifyTargetFramework" BeforeTargets="Build">
        <!-- It is possible to override our TFM via global properties. This can lead to successful builds, but runtime errors due to incompatible dependencies being brought in. -->
        <Error Condition="'$(TargetFramework)' != 'net6.0'" Text="The target framework '$(TargetFramework)' must be 'net6.0'. Verify if target framework has been overridden by a global property." />
    </Target>
</Project>

Its then restoring the project itself:

image

This generated project contains a transitive reference to a different Newtonsoft.Json which is why NuGet is installing it.

I'm not sure exactly how this SDK works but you can see if there's an existing issue or file a new one at https://github.com/Azure/azure-functions-dotnet-worker/issues

Workarounds
There are no known workarounds

Steps to reproduce

  1. Open Visual Studio, choose to create a new project
  2. Search for Azure Functions. Choose it and click Next
  3. In the Additional Information window, choose .NET 8.0 Isolated (Long Term Support) and Durable Functions Orchestration
    Snag_9787fe
  4. Click Create
  5. Double-click the csproj file and see that nuget restore adds a few packages
    Snag_9c68d5
  6. Build your project
  7. Open File Explorer, look inside the .nuget packages newtonsoft folder. i.e. C:\Users\username\.nuget\packages\newtonsoft.json. You will notice that NuGet downloaded versions 9.0.1, 10.0.1, 10.0.2, 11.0.2 13.0.1
  8. Delete ALL versions/folders from C:\Users\username\.nuget\packages\newtonsoft.json. The folder should now be empty.
  9. Add this XML to your .csproj: <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
  10. Adding the XML above should force NuGet to download ONLY 13.0.3, for any and all transitive dependencies.
  11. Rebuild the project and notice that it does not download only 13.0.3. It incorrectly downloads all prior versions again
jviau commented

Transferred to azure-functions-durable-extension to track this. With the current SDK the resolution is for the worker extension owners to release versions that bring in a WebJobs extension with transitive CVE's addressed.

mikejohnstonPremierinc commented

@mikejohnstonPremierinc have you tried using latest durable extension 1.2.1? https://www.nuget.org/packages/Microsoft.Azure.Functions.Worker.Extensions.DurableTask

@jviau I have not. Can you tell me the exact steps to try, then I will reply if it worked? Thanks!

jviau commented

@mikejohnstonPremierinc update the line <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.DurableTask" Version="..." /> to have a version of 1.2.1

mikejohnstonPremierinc commented

@jviau I have now tried this, and this did not work.