Azure/azure-monitor-baseline-alerts

[Question/Feedback]: Syntax defaultValue vs defaultvalue

Closed this issue · 5 comments

steph409 commented

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Description

Hi,

I am currently writing the terraform implementation for the amba. When I deploy the policies per script and them manage via terraform, I saw that there is a configuration drift for 12 policies. Examplary, I put one example here, where you can see in pink the changes defaultvalue vs defaultValue and allowedValues vs allowedvalues.

When you look at the definition file and search for e.g. defaultvalue, you can see that it is inconsistent in the json-files. Is there are reason for it?

image
Brunoga-MS commented

Hello @steph409 ,
thanks for your feedback. There's no reason for this difference. It's more about the syntax checker some time not enforced. They do behave exactly the same so you can ignore this difference in JSON. Is it creating any problem in Terraform?

Thanks,
Bruno.

steph409 commented

Hi Bruno,
thanks for the quick reply. For terraform, it is annoying because terraform tries to update the resources each time it runs (inconclusively). If you don't mind, I will prepare a pull request with the changes, to make the configuration consistent. I just don't wanted to go through the work, and then learn that there is a reason for the differences.
BR, Stephanie

Brunoga-MS commented

@steph409 fine to me and thanks in advance :-)

steph409 commented

Hi @Brunoga-MS,

I found one more of those problems while implementing the terraform version: once it is FrontDoor, once Frontdoor, also resulting in errors in terraform, as the [terraform policy provider ](https://registry.terraform.io/providers/Azure/alz/latest/docs) we have is case sensitive and can't find the policy then. I will update my PR accordingly

image
Brunoga-MS commented

@steph409 : perfectly fine and thanks.