Azure/azure-sdk-for-python

Servicebus azure.servicebus._pyamqp.message.Message types don't match usage in this package's unit tests

travcunn opened this issue · 2 comments

travcunn commented
  • Package Name: azure-servicebus
  • Package Version: latest
  • Operating System:
  • Python Version: 3.10

Describe the bug
The types from azure.servicebus._pyamqp.message.Message don't match those in the unit tests.

In commit f8f223d, Message.data is now forced to a type: data: Optional[bytes] = None, however in unit tests in this package, it is treated as an array. See these tests:

azure-sdk-for-python/sdk/servicebus/azure-servicebus/tests/test_message.py

Line 175 in 5fd2c52

data=[b'data'],

Does the linter on this package not scan unit tests? Can you please fix the types on the Message class?

github-actions commented

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @EldertGrootenboer.

kashifkhan commented

Thank you for the feedback @travcunn . We will investigate and get back to you asap.