Node History Problem

cyclecloud-scalelib/src/hpc/autoscale/node/nodehistory.py

Lines 154 to 161 in 4efda02

    
           if node_id not in rows_by_id: 
        
               # first time we see it, just put an entry 
        
               rows_by_id[node_id] = tuple([node_id, node.hostname, now, now]) 
        
           if node.required: 
        
               rec = list(rows_by_id[node_id]) 
        
               rec[-2] = now 
        
               rows_by_id[node_id] = tuple(rec)

In SQLiteNodeHistory.update, a new node (not in database yet) will be stored in datebase with a fresh last_match_time, no matter the node.required is true or not. Is it a problem? If an unrequired node can be saved with a fresh last_match_time, then what does the last_match_time really mean?

	if node_id not in rows_by_id:
	# first time we see it, just put an entry
	rows_by_id[node_id] = tuple([node_id, node.hostname, now, now])

	if node.required:
	rec = list(rows_by_id[node_id])
	rec[-2] = now
	rows_by_id[node_id] = tuple(rec)