Improve readability and extensibility in the test suite
aaronburtle opened this issue · 1 comments
Across our test suite, we have a number of tests that have correct functionality but can be difficult to modify and have some readability issues. Things like code duplication, and hard coded values can make updates to the test time consuming.
As an example, take this test from GraphQLPaginationTests.RequestAfterTokenOnly
Because of how the expected values are coded, if for example we want to update this test because we have a case where the after token is not of this form, it requires us to add another conditional that matches the new case and then has the expected value setup their. This is difficult to read, and slow to update.
As we expand our functionality we will require updates to our test suite, and improving readability and extensibility will be useful.
One candidate for code duplication is the test class used in this PR
which has many spots where code is duplicated across many tests.
- TestRelationshipForCorrectPairingOfLinkingObjectWithSourceAndTarget