Azure/orkestra

Handle false success case when HelmRelease toggles between ready and other states

nitishm opened this issue · 2 comments

nitishm commented

Describe the bug
HelmRelease are occassionally seen to toggle between Ready state and other status', mostly right after they are created. The executor should handle this scenario in a smarter way by doing periodic checks on the HelmRelease status prior to returning success.

To Reproduce
Hard to reproduce as it is sporadically seen.

Expected behavior
Handle this bug in helm-controller gracefully by verifying that the HelmRelease has settled in the Ready state before returning success

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • Kubernetes Version [e.g. 1.21.0]
  • Kubernetes Distro [e.g. AKS, GKE, etc.]
  • Orkestra Version Tag
  • Helm Version

Additional context
Add any other context about the problem here.

nitishm commented

@jonathan-innis can this be closed? Since you put the retries to confirm the status in the workflow executor?

jonathan-innis commented

Yep, let's close it 🎉