Azure/terraform-azurerm-avm-res-storage-storageaccount

Should this repository be cloned from AVM template?

kewalaka opened this issue · 3 comments

kewalaka commented

Is there an existing issue for this?

  • I have searched the existing issues

Expected Behaviour

From the AVM guidance (https://azure.github.io/Azure-Verified-Modules/contributing/terraform/#template-repository) recommends using the following template as the starting point:

https://github.com/Azure/terraform-azurerm-avm-template

I've noted that this repository aligns to the previous "terraform verified modules" and thus there are some changes require set the types and use a slightly different CI approach.

Actual Behaviour

Unsure - is the plan to make changes to this repo, or should it be re-created from the AVM template?

Steps to Reproduce

No response

Important Factoids

No response

References

https://azure.github.io/Azure-Verified-Modules/contributing/terraform/#template-repository

kewalaka commented

hi @chinthakaru - do you have any feedback on this? As per the issue on the AVM project here:

Azure/Azure-Verified-Modules#35 (comment)

Quoting my feedback on this issue:

ok cool. I've got a little present for you all - based on the initial work from @lonegunmanb i've refactored things into an AVM style here (clone off the right template):

https://github.com/kewalaka/terraform-azurerm-avm-res-storage-storageaccount

it's still work in progress, the AVM interfaces are implemented. Some basic E2E tests are passing though (default settings + a storage acc + container with access keys disabled, private endpoints), my plan is to re-introduce the complete example once I've got a bit more confidence.

matt-FFFFFF commented

As discussed, this was a special case and we will remediate required changes to AVM here: https://github.com/Azure/terraform-azurerm-avm-res-storage-storageaccount/tree/avm-sa

alraea commented

Hello,

This module was already published to the Terraform registry, but under it's old name (changed by 1aa1e79).

I am pretty sure that it was there a week ago, but now it's gone (hence #24 ) , I think that renaming and removing it without a mentioning that in the README.md or the description of the project is not fair.