BHoM/ETABS_Toolkit

ETABS_Engine.dll is not capitalised in the same way as other ETABS DLLs

FraserGreenroyd opened this issue · 3 comments

FraserGreenroyd commented

image

ETABS_oM and ETABS_Engine DLLs are not capitalised the same way. It appears that the full capitalisation is correct based on the adapters and the repo name, so probably best to change Etabs_Engine to ETABS_Engine - but if that is not correct then please fix the others instead 😄

IsakLarbornBH commented

image

This is why. I'd submit a PR, but I'm not experienced enough to know if changing this might have any other consequences that need to be dealt with.

IsakNaslundBh commented

That is it @IsakLarbornBH . Would not make this change this week though (even though I think it is probably safe.

But lets target to get it resolved early after 4.0 is out of the way.

  • 👍1
FraserGreenroyd commented

That is indeed why @IsakLarbornBH - I'd say submit a PR if you're up for it and then it's down to your reviewers to help work out the consequences, @IsakNaslundBh will be able to guide you 😄

From a CI/CD perspective - no impact on our side, so it'll only be potentially impacting something structures side.

Edit: I'd say submit the PR but @IsakNaslundBh says not to so hold for his clearance 😄

  • 👍1