BSVino/docs.gl

textureGather's description is wrong

Closed this issue · 2 comments

NicolBolas commented

The website says this:

vec4(Sample_i0_j1(P, base).comp,
     Sample_i1_j1(P, base).comp,
     Sample_i1_j0(P, base).comp,
     Sample_i0_j1(P, base).comp);

But the GLSL specification says this:

vec4(Sample_i0_j1(P, base).comp,
     Sample_i1_j1(P, base).comp,
     Sample_i1_j0(P, base).comp,
     Sample_i0_j0(P, base).comp);

Note the last one, with the 0,0 i,j value.

This mistake is also in the textureGatherOffset and textureGatherOffsets functions.

BSVino commented

Care to make a PR?

leumasme commented

Why is this issue still open if the closing PR has been merged?