BUPT/clubber.ml

PR合并的注意事项

Opened this issue · 4 comments

大家在发起PR的时候可能会存在多条commit,原因有很多,例如:

commit

这样直接合并之后,会使得repo的commit history变得凌乱

所以chairs在合并PR的时候,根据情况,尽可能的选择Squash and merge,这样可以将多条commit合并成为一条commit,使得整个repo的commit history看起来更加清爽

merge

Great idea from an OCD patient 😆. I agree with you, however.

huan commented

This is a very good rule that we should follow it definitely!

Could you please also add this to our Pull Request Manual: https://ai-ml.club/manuals/pull-request/ , so that members will be able to see it at the very first time?

I have already added the notification in docs/pull_requst and docs/manual in my Oral PR. @linbo0518 @huan

huan commented

Awesome, glad to know that! @824zzy