Bachmann1234/java9_kernel

Multi Line Code Throws EOL forcing kernel restart

Closed this issue · 5 comments

Recent Changes in Kulla.jar seem to have broken the kernel.

I have updated the code. But now multiline code just hangs and eventually crashes

In [1]: int i = 0;
int i = 0;
i ==> 0


In [2]: System.out.println("test");
System.out.println("test");
test


In [3]: if(true) {
Restarting java

I tried fixing this by setting the shell in the following way

self.javawrapper = replwrap.REPLWrapper(
                "{} -jar {}".format(
                    self._JAVA_COMMAND,
                    self._KULLA_LOCATION
                ),
                u'jshell> ',
                """/set mode jupyter
/set prompt jupyter "{0}" "{1}"
/set feedback jupyter"""
            )

But that does not seem to work as I had hoped.

If this gets fixed update this wiki to make it clear its not broken anymore

https://github.com/ipython/ipython/wiki/IPython-kernels-for-other-languages

I'll take a look at this too when I get back from vacation in a couple of
weeks.

On Sun, Jun 19, 2016 at 11:52 PM, Matt Bachmann notifications@github.com
wrote:

If this gets fixed update this wiki to make it clear its not broken
anymore

https://github.com/ipython/ipython/wiki/IPython-kernels-for-other-languages


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#20 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAKSeCQ7DzfA_w6UJD7YRlXl4XXkkSxaks5qNg5zgaJpZM4I5RvI
.

The issue is not reproduced with latest jdk9 and Kulla.jar.
I was able to create fully functional java9 notebook.
Here is a proof of concept docker container: https://github.com/moisei/java9_kernel/tree/docker

I have confirmed that that jar works outside the docker and inside the docker. Thanks!