validate to be registered contract has check and perform upkeep selectors
Closed this issue · 4 comments
have not found a reliable manner to determine this on-chain, which leads me to think why they opted themselves as well to handle in the f/e level
always we should assume that contract B, could have fallback, when identifiers do not match the targeted. In our case, we will have the contract to go thru the msig repo thru a 2/n review, which could behave as similar as their f/e check-up at the end of the day
@gosuto-inzasheru lmk your thoughts or if you aware of a reliable on-chain way to handle it
what do you mean by "that contract B, could have fallback"? as in the check and perform upkeep functions are called from the fallback function, and are therefore not visible as a function in the contract itself?
what do you mean by "that contract B, could have fallback"? as in the check and perform upkeep functions are called from the fallback function, and are therefore not visible as a function in the contract itself?
was referring to the case that could not find an on chain way to verify that those methods exists reliably. so adding a contract as a member, we should assume that could have a fallback method, which could get trigger if for example performupkeep does not exist and the content of the fallback being malicious
closing since it has being integrated Badger-Finance/badger-multisig#1133