Baekalfen/PyBoy

requirements.txt installs Cython only on CPython, but setup.py tries to use it on anything that is not PyPy

Closed this issue · 4 comments

The requirements txt leads to Cython not being installed on e.g. GraalPy, but then setup.py tries to Cythonize, because GraalPy is not PyPy

PyBoy/setup.py

Line 19 in 311562a

cython>=0.29.16; platform_python_implementation == 'CPython'

PyBoy/setup.py

Line 35 in 311562a

CYTHON = platform.python_implementation() != "PyPy"

Thanks for pointing this out. Would you want to use Cython with GraalPy?

Preferably not, we have a similar C API emulation layer as PyPy and like PyPy it is generally better for us to JIT the Python code instead of trying to emulate CPython's API.

Understood. If it's simply changing those two statements, could you make a PR of how it works for you? I don't have a lot of spare time to test it out with GraalPy myself.

Thank you!