Baekalfen/PyBoy

Kirby's Dream Land: Plugin bug

Closed this issue · 2 comments

I noticed some bug when using the game_wrapper() of Kirby's Dream Land.

  1. The GameWrapperKirbyDreamLand().score doesn't calculate score correctly. The digits are calculated in reverse to their location in memory.
  2. The GameWrapperKirbyDreamLand().game_over() should return true if lives_left==0, not health==0. Not sure if this is intended but this cause problem when trying to use the game_over() function to decide the terminated state in custom gymnasium.Env.step().

May I make a pull request regarding to the bugs?

image

Yes, that looks reversed. You're welcome to submit a PR with fixes for both things

Fixed in #263