Baizey/UniversalAutomaticCurrencyConverter

Manual conversion rate seems broken

Opened this issue · 9 comments

No custom display:
imagen
With custom display:
imagen
Conversion rate: 76
Live example works.

do you have a url for this bug?

in custom display what is your conversion rate set to?

I see, it's showing 72.56 * 76 = 5514.56 rather than 5514.82

While it always display values to at most 2 decimals spots, it actually works with as many as necessary in the background, so the value is likely not 72.56 exactly, but somewhere between 72.565 > x >= 72.555 (and if calculated in reverse 5514.82 / 76 we get ~72.563) so it's within "error margin" on the display

Wait what? Why "72.56 * 76 = 5514.56" and not "1 * 76"? Argentinian currency changes way too often to consistently correct with corrections to the conversion provided by your servers (which is wrong). Also, that is very unintuitive.

it is "1 (USD) * 72.5634.... (ARS conversion rate) * 76 (custom rate)"

it does not take over, it multiplies onto

As for how often the extension update rates:

If you want to provide either a paid tier for a currency rates API or pay to increase server capacity I am all for making it update more often.

"1 (USD) * 72.5634.... (ARS conversion rate) * 76 (custom rate)"

This is unsustainable.

If you want to provide either a paid tier for a currency rates API or pay to increase server capacity I am all for making it update more often.

The problem is not the "ofteness" its the "incorrectness", your APIs updates are very out of date, since they are published. See here for a correct update to compare: #12 (comment), direct link to visual version.