CountingBloomFilterRedis#remove() destroying the Redis Pool
edrabc opened this issue · 1 comments
edrabc commented
The Redis Pool could be shared between several BloomFilter instances. If one of the filters is removed filter.remove()
, the Redis Pool is destroyed. This makes the rest of active filter instances unusable:
@Override
public void remove() {
clear();
pool.safelyDo(jedis -> jedis.del(config().name()));
pool.destroy();
}
bfelaco commented
👍 I'd submit a pull request to remove this line but I have no idea why it's there and what else it could impact and if other changes are required to compensate.