Barthelemy/CppProjectTemplate

Windows compatability

staal opened this issue · 1 comments

staal commented

Hi there,

I stumbled upon your repo searching for doxygen usage in cmake. I like the idea behind it but it's not really well structured for Windows, Visual Studio specifically. I would really remove "SHARED" from build targets, using the standard way to build shared by setting the flag BUILD_SHARED_LIBS in your cmake cache. See https://cmake.org/cmake/help/v3.0/variable/BUILD_SHARED_LIBS.html#variable:BUILD_SHARED_LIBS

Windows shared(DLL) creation is slightly more involved, again see https://cmake.org/Wiki/BuildingWinDLL

In your Doxygen.in files you should modify DOT_PATH to be:

DOT_PATH = @DOXYGEN_DOT_EXECUTABLE@

That way you don't need Graphviz on PATH, but can define it yourself.

I could make a PR with the above mentioned changes, plus cleaning up some deprecated cmake ways since 3.0 if you'd accept it.

Hi,

Sorry for the late reply, I was away for a few days.

Thank you for your comments. I have not tested the project on windows. I would be grateful if you could make a PR and I would then test it on Linux and Mac (and Windows).

Concerning the clean up of deprecated CMake, the project is compatible with CMake > 2.8. Would your changes force users to use CMake > 3 ?

Cheers,