BartoszJarocki/cv

The toolbar feature is not displayed with the right condition

tonytangdev opened this issue · 1 comments

Bug Report

Description:
I just cloned the repo and noticed that it was missing the feature to switch language and to switch theme.
I looked at the code and found out these features were implemented but they were hidden.
I saw that I had the features enabled by looking at the app,config.ts : https://github.com/dninomiya/cv/blob/main/app.config.ts#L17

How to reproduce:
Have the features print, theme and locale enabled.

Expected Behavior:
We should have the features displayed on the toolbar
Screenshot from 2024-01-22 14-29-36

Actual Behavior:
We cannot see the features on the toolbar.
Screenshot from 2024-01-22 14-28-56

Possible Solution:
I suggest we change noFeatures declaration like so :

const noFeatures = Object.values(AppConfig.toolbar).every((value) =>
    !Boolean(value)
  );

Sorry I messed up. The issue is for another repo :/