Script freezes updating docker compose.

I recently updated to 4.1 and the new way that docker is handled is ineffective. It's running find on /.
There are a few issues with this approach. This is very broad and very slow. Even when the containers storage in on a gen4 nvme drive, this never completes. It only eats up ram, forcing a reboot to reclaim.
Another issue with this approach is compose files can be named anything you want. So searching docker-compose.yaml/yml will not get all compose files.

Hi @bleach86,

for docker issues pls test latest development version with update develop -up

The reason is it's normal for the script when you put / as path is go gonna look up inside every folder of the container and the command he did it isn't the best in terms of performance, also we've followed the convention of docker compose naming, and the correct name is the fourth we put in the script.
If you want to search for your docker compose, put them in the same folder inside every container like /home and your didn't have any issue with it.

Edit: are you talking about the recent change on master or develop branch ?

The reason is it's normal for the script when you put / as path is go gonna look up inside every folder of the container and the command he did it isn't the best in terms of performance, also we've followed the convention of docker compose naming, and the correct name is the fourth we put in the script. If you want to search for your docker compose, put them in the same folder inside every container like /home and your didn't have any issue with it.

Edit: are you talking about the recent change on master or develop branch ?

Searching / is hardcoded:

Proxmox/update-extras.sh

Line 89 in 4a2af25

    
           if COMPOSE=$(find / -name "docker-compose.yaml" >/dev/null 2>&1 | rev | cut -c 20- | rev | tail -n 1); then

This is version 4.1 from the main branch.

Oh ok so please could you update to develop branch with this command please : update develop -up

Hi @bleach86,

for docker issues pls test latest development version with update develop -up

I'm running it now. So far it is doing the same thing.

Hi @bleach86,
for docker issues pls test latest development version with update develop -up

I'm running it now. So far it is doing the same thing.

Have you put the right folder in the update.conf file ?

Hi @bleach86,
for docker issues pls test latest development version with update develop -up

I'm running it now. So far it is doing the same thing.

Have you put the right folder in the update.conf file ?

this is just a default install. the only change to the config I made was to disable docker because it is just effectively a memory leak.

I see in the dev branch the find is on /home, but I'm seeing it on / still for some reason

Maybe uninstall the script and reinstall it with develop branch
To uninstall: bash <(curl -s https://raw.githubusercontent.com/BassT23/Proxmox/master/install.sh) uninstall

I see in the dev branch the find is on /home, but I'm seeing it on / still for some reason

Pls don't set the path to / this result in error. Pls use your correct folder 😉

I see in the dev branch the find is on /home, but I'm seeing it on / still for some reason

Pls don't set the path to / this result in error. Pls use your correct folder 😉

I dont see where and it also still appears to be hardcoded anyway. but for some reason even after uninstall and reinstall it is still doing find /. Here is the weird thing. Once it finally finished, it ignored docker in all of my other containers. this container has docker installed, but nothing actually running. My other containers with containers actually installed and running did nothing. update --version says 4.1.2

Didn't this used to update all the docker containers instead of just ones ran with compose?

Thanks, you made me think where the problem was and found at that the compose path variable was missing in the develop branch I've actually added it you can now run update develop -up and everything should be fine.

or make this:

rm -rf /etc/ultimate-updater && bash <(curl -s https://raw.githubusercontent.com/BassT23/Proxmox/master/install.sh) install && update develop -up

Working for me now !

Working for me now !

Same here! Not getting stuck and it is actually updating the containers!

Thanks for the assistance and hard work!

Edit: Also, thanks for that one liner, that saved me. It was giving all sorts or file not found errors before that.