Bastian/bstats-metrics

Clarify why relocating bstats is not necessarry for bstats-sponge

Shynixn opened this issue · 3 comments

Shynixn commented
  • Can you please clarify why I do not have to relocate the bstats package when using Sponge?
  • What happens if someone else shades a different bstats version to the same classpath?
    org.bstats.sponge
Bastian commented

To be honest, I don't know.
Most of the code for the Sponge Metrics class was rewritten my @mbax in #38.
My current guess would be, that Sponge has a different class loader per plugin and thus it doesn't matter.
Maybe @mbax can elaborate the reasoning behind it a little bit better.

Shynixn commented

Thank you for your reply!

Yes, this would be interesting.

Bastian commented

While it's probably technically still not necessary, the new Sponge Metrics classes (2.x.x) now require relocation again.