BeAPI/acf-svg-icon

[Object object] text for selected icon

jmslbam opened this issue · 3 comments

jmslbam commented

Hi there,

First of all, thank you for the plugin! I'm encoutering and issue that a selected icon gets displayed as [Object object]. All of them.

I tried to debug is, but without succes. It isn't get_nice_display_text nor or bea_svg_format_small(css).

A pointer in the proper direction can help, so I can open a PR when needed.

Ciao!

PHP 7:3
WordPress 5.3.1
Plugin Name: Advanced Custom Fields: SVG Icon
Version: 2.0.4

Screenshot 2020-06-25 at 10 57 17

Screenshot 2020-06-25 at 10 57 21

jmslbam commented

Ah, it is bea_svg_format,

And I'm running ACF Pro Version 5.8.3

jmslbam commented

Sorry, still debug, can't find out which one it is :)

jmslbam commented

so it uses `bea_svg_format_small,

And I fixed it buy using call .html() right here https://github.com/BeAPI/acf-svg-icon/blob/master/assets/js/input-56.js#L52

return $('<span class="acf_svg__span" data-id="' + css.id + '">' + css.text + '</span>').html();

Is it me? The Jquery version? The Latest update? Open for a PR?