BeaconCMS/beacon

Bug: PageModuleLoader calls wrong render function

scrusi opened this issue · 3 comments

scrusi commented

Hey, thank you for your great work.
In trying to check out Beacon, I noticed that #376 seems to have introduced a bug that prevents pages from rendering, at least in the default setup.

Beacon.Loader.PageModuleLoader calls Beacon.Template.render/1 with assigns although it expects a page module. Calling render/2 seems to fix the issue, however I know too little about Beacon to submit a PR right now.

Beacon.Loader.PageModuleLoader:44
%Phoenix.LiveView.Rendered{} = rendered <- Beacon.Template.render(page_module, assigns) do

Hope that helps

lessless commented

Thanks for reporting @scrusi.
I'm bitten by this as well

krns commented

I think I have the same problem. If I refresh the page fast enough, my page content eventually renders.

beacon.mov
leandrocp commented

My bad, a refactor gone wrong. It should be fixed by #380, please give it a try.