BeardedBear/bearded-theme

Contrast issues in Terminal

Closed this issue · 7 comments

Contrast seems to break a bit when using lighter backgrounds with light text-color in the terminal.
For example

Using the Monokai Black variant: (but the issue persists across all dark color-variations)
image

Using the Coffe Cream variant seems to break even more:
image

For reference, using the default Dark theme for VSCode:
image

A current "workaround" is just highlighting the invisible text:
image

I can't reproduce this bug, can you tell me more about how you achieve this result?

Sure thing! To reproduce, I used this command1:

echo "\n This is readable! \033[0;100m This isn't! \033[0m\033[90m"

Which resulted in this output:

Normal:

image

With the text highlighted:

image

(Both times using the Bearded Theme Oceanic)

Switching back to Dark (Visual Studio) displays the text with background correctly:

image

Footnotes

  1. A gist with the ANSI codes explained

I have the same issue with using HC Ebony theme. The suggestions from rails console is unreadable.

image

I fixed it this way,

  "workbench.colorCustomizations": {
    "terminal.ansiBrightBlack": "#374151"
  },

this is what it looks like right now

image


I think the problem is with the default value for terminal.ansiBrightBlack which is #c8c8d566.

@SyedMSawaid @B4T3S can you tell me which OS you're using, and which shell? I'm on Windows and I don't have this problem at all :/ the only thing that differs from the other terminal colors is that I use opacity. So if you don't mind, I'll provide you with a version to install locally via the extension tab (a .vsix file) so that you can try it out :/
9.1.5-preview.zip

Sure thing! The preview seems to fix the issue!

(Although for some reason my terminal decided that ANSI codes aren't a thing anymore, unless they're coming from a python shell lol)
image

Regarding what OS and shell I use:

  • Privately I'm running Win11 with the Git Bash shell, so "normal" bash.
  • At work I'm running Fedora with the ZSH shell

Edit:
I tested with the Bearded Theme Black and Ruby Soft in the screenshot, but I've cycled through all themes and it works with all of them 👍

@BeardedBear I was facing this issue with Windows 10 + WSL.

I moved to Mac a couple of days ago and teared down my windows dev environment so I can't test the preview now. Sorry :/

My theory is that opacity would have some issues with WSL. When I removed the last two letters of the original #c8c8d566 value, it started working. But the contract wasn't that great so I changed it to #374151.