Remove a:b in defines
Opened this issue · 1 comments
PowerfulBacon commented
a:b syntax can massively increase compile times, I had ~5-6 calls inside of a define that was called ~400 times, which increased compilation times by 2 minutes. With some very, very rough maths that means each a:b call is something like 50ms of compile time, which when inside a define that is used a lot can really increase the compilation times.
I only noticed this due to a single PR increasing it to ~2:30 minutes, but we could have had smaller PRs adding these going under the radar.
PowerfulBacon commented
Opendream have added a lint against this, which we can use (OD3300)