BelledonneCommunications/liblinphone

[Bug]: Incorrect number length(s) in dialplan

Closed this issue · 1 comments

vhartikainen commented

Context

This library is included in the linphone-sdk we're using in our project.

General information

Device agnostic

Expected behaviour

  1. Retrieve Dialplan for a Finnish mobile number
  2. Check nationalNumberLength
  3. Expect to return a correct length based on ITU-T numbering plans

To Reproduce

  1. Retrieve Dialplan for a Finnish Number: +3584012345678
  2. Expect to return nationalNumberLength=10 (there could be longer numbers in Finland too)
  3. Instead, 9 is returned, which will lead to incorrect number formatting (i.e. +358012345678)

Additional example:

  1. https://paradisehotelnorfolk.com/ - +672322177
  2. Will not work

Additional context

Suspect other nationalNumberLengths are too outdated. These should be compared against ITU-T standards instead of potentially inaccurate wikipedia sources. This might lead to problems with customers dialing phonenumbers.

See e.g. https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000490003PDFE.pdf

See: https://en.wikipedia.org/wiki/List_of_mobile_telephone_prefixes_by_country
Seems to have Finnish Mobile numbers with lengths: 8-11

Clearly dialplan data is outdated.

liblinphone/src/dial-plan/dial-plan.cpp

Line 146 in 9ed7db9

DialPlan::create("Norfolk Island", "NF", "672", 5, "00", "🇳🇫"),

liblinphone/src/dial-plan/dial-plan.cpp

Line 87 in 9ed7db9

DialPlan::create("Finland", "FI", "358", 9, "00", "🇫🇮"), DialPlan::create("France", "FR", "33", 9, "00", "🇫🇷"),

SDK logs URL

No response

Viish commented

Hi @vhartikainen,

This was fixed in commits 3ab0379 & 8688b2a

Cheers,