BentoBoxWorld/Upgrades

Command upgrades show 1/0 all the time

JHarris12345 opened this issue · 11 comments

For command upgrades, it says the tier name but then always 1/0 like this:

image

My config is https://pastebin.com/i4ULemiJ

Sorry @Guillaume-Lebegue why was this closed with no fix

It's fixed, this issue was automatically closed with the corresponding commit

Ive downloaded the latest jar and its not fixed though. still says 1/0

Did you do a full restart of your server?

I think I found why. Can you check if it work ?

@Guillaume-Lebegue It's fixed but not correct. The [current] placeholder is showing your current level +1. I have 3 member upgrades, but without having upgraded it at all, it says im on 1/3. Instead of 0/3 OR 1/4. Becuase that means, by the time ive upgraded it twice, it says Ive done 3/3 (implying there is no further to go), when there is.

Well, Actually, that's correct, [Current] Show the level of this level, not the level of the user.
So by default, it shows 1 because it's the first upgrade.

then [max] should show 1 extra. Because I think we can agree that showing 3/3 when you arent done is a bit weird. Either max needs to go up or [current] needs to go down

Or current should show the level of the user. It just makes sense that current is your current level, not the next level

You're right with that, however, I won't do a rework on that for now, because I will soon update this interface with something way better

Ok thanks :D