Range Conflict with Upgrade addon
myavuzokumus opened this issue · 5 comments
Expected behavior
Island range do not return to their default values after upgrade, even if the island owner does not have permission.
Observed/Actual behavior
After upgrading the island ranges in the upgrade plugin, the island borders revert to default values because the island owner does not have the necessary permissions.
Steps/models to reproduce
After upgrading the island borders with the Upgrade addon, login to the server again. Your borders will shrink.
BentoBox version
Plugin list
No response
Other
No response
Currently, the permission bskyblock.island.range.x has priority when logging in, so that is why it is reset. If the owner has no permission set, then the range remains. Right now, the only option/workaround is to not mix permission ranges and Upgrades.
I did look at trying to update the player's permission, but this became messy. First, Upgrades allows non-owners to purchase range upgrades (this could be changed). If the owner is not online, then there's no way to update their perms. However, adding perms through Bukkit doesn't always work with plugins like LuckPerms, so it's unreliable. I tried it and I couldn't get LuckPerms to accept the new permission.
The "real" way to do this would be for BentoBox to support range bonuses in the island data object. That would require a new version of BentoBox. That's quite a big change though, so I need to think about it.
I would love the "real" approach.
It would allow to better integrate with Boxed advancements and Challenges/Tasks addons :)
Currently, the permission
bskyblock.island.range.xhas priority when logging in, so that is why it is reset. If the owner has no permission set, then the range remains. Right now, the only option/workaround is to not mix permission ranges and Upgrades.
Actually, players don't have bskyblock.island.range.x permission, I already mentioned that. As you said, I think a support is needed on the Bentobox side. What exactly is the reason why the game mode is changed to the default island limits in the settings file when the players don't have the permission?
Currently, the permission
bskyblock.island.range.xhas priority when logging in, so that is why it is reset. If the owner has no permission set, then the range remains. Right now, the only option/workaround is to not mix permission ranges and Upgrades.Actually, players don't have
bskyblock.island.range.xpermission, I already mentioned that. As you said, I think a support is needed on the Bentobox side. What exactly is the reason why the game mode is changed to the default island limits in the settings file when the players don't have the permission?
Uhmm, thats my fault XD. Players does have bskyblock.island.range.x. I thought they doesn't have. Then if you want close issue or you can bring thats feature for possible next generation issues.
Thanks for clarifying. I actually agree with @BONNe though that having a way to set bonus ranges in BentoBox will be a good feature. I'll work on it.