Warps not being removed when using /editsign from Essentials
vyvin opened this issue · 2 comments
Expected behavior
If a sign is edited to remove the [Welcome] or whatever first line requirement for the warp, the warp should be deleted
Observed/Actual behavior
Warp isn't deleted and can still be warped to
Steps/models to reproduce
- place a sign with [welcome] as the first line
- edit the sign with /sign set 1 (something)
- check the /ob warps
-
- See that the warp still there
BentoBox version
bbox version
[21:43:11 INFO]: Running AIRPLANE 1.17.1.
[21:43:11 INFO]: BentoBox version: 1.17.3
[21:43:11 INFO]: Database: JSON
[21:43:11 INFO]: Loaded Game Worlds:
[21:43:11 INFO]: oneblock_world (OneBlock): Overworld, Nether*
[21:43:11 INFO]: Loaded Addons:
[21:43:11 INFO]: AOneBlock 1.9.0-SNAPSHOT-b214 (ENABLED)
[21:43:11 INFO]: Border 3.2.0 (ENABLED)
[21:43:11 INFO]: Challenges 0.8.4 (ENABLED)
[21:43:11 INFO]: Chat 1.1.4 (ENABLED)
[21:43:11 INFO]: Level 2.7.2 (ENABLED)
[21:43:11 INFO]: Warps 1.11.1 (ENABLED)
Plugin list
No response
Other
No response
Well, essentials are not developer-friendly... and never was.
It is not possible to detect that sign was edited, so, the only thing that could happen:
- add an extra check before warp is used that checks if the sign still contains
[welcome]text.
This fix is just in one way. So if a player wants to edit the sign and place [welcome] text by activating the warp, it will not work.
Yeah, it would seem the only fix is to prevent the Essential command via permissions. Sorry about that.