Bhinneka/gubrak

feat: Set maximum call and concurent call separately

bxcodec opened this issue · 5 comments

Current version:

In the current version, we can set the maximum concurrent call that was called concurrently.
For example:

./gubrak -r 100 -c config.json

This command will do 100 call with 100 concurrent request. So if I set the r param to 1000 then I will make a 1000 call with concurently.

What I proposed is:

How about making maximum call but we can set the maximum concurrent call separately
maybe something like this:

./gubrak -r 1000 -concurent 100 -c config.json

I'll expect this, we made a 1000 call in total, but separated in 10 times (1000/100) or to simplify, it's like doing batching calling 100 call per batch until it reach 1000 as the targeted total call.

Because we don't have any clear roadmap yet, I think we can add this one to our development plan.

so we can control how many goroutines we will launch and also how many requests we will launch, but not directly related, is that right @bxcodec ?, i think its good.
is the -concurrent flag mandatory? if not, will the -concurrent use the size of request?

I think it's better to use a default parameter.

well,, now we just have to think about the design of this new feature

So who will add this feature?
It's so busy lately, but maybe in the next week, I'll try to fix this.