Modbus-Response-Filter doesn't work
Kortenbach opened this issue · 10 comments
I'm submitting a ... (check one with "x")
Problem
- (x) bug report => please search github for a similar issue or PR and test Modbus problems with the modbus-serial package before submitting
- ( ) unexpected behavior => please visit the Wiki before
Current behavior
Node "Modbus-response-filter" issues an error "Error: 0 does not match 8". After "fixing" this error by entering "0" instead of 8 under "Modbus-Response-Filter-->Properties-->Registers" the error disappears but the filter doesn't work. This is because Message.payload always is a zero length array instead of an array with actual values in it.
It seems like the filter node was not updated after a major code revision, so it's broken now.
Expected behavior
A working filter based on the names in the JSON file.
Minimal reproduction of the problem with instructions
- Install Modbus Nodes into Node-red
- Create a valid JSON file from your Codesys device CSV (checkout the Wiki for howto and errors in the node example that does this)
- Use the Simple-modbus-IO-demo flow to test.
- Change the filter to find an existing name
- Check out the errors
Your Environment
Using build-in node-red-contrib-modbus server
Using latest build of node-red-contrib-modbus
-
Device :
- ( ) macOS: v
- ( ) Linux: v
- (x) Windows: v
- ( ) Raspbian: v
- ( ) Other:
- Name:
- Version:
-
node-red-contrib-modbus version: latest
- Node: latest
Hi, could you send the debug result before the Response-Filter? The error means, that your array should have 8 entries, but it has input via msg with 0 entries. The Response-Filter has some protection, that wrong readings are filtered out if the amount of expected entries gets wrong.
This issue is stale because it has been open 60 days with no activity. It will be closed in 30 days, but can be saved by removing the stale label or commenting.
Hi @biancode,
Sorry for not responding. Your message seems to have slipped by. Meanwhile I stopped using the node and coded my own workaround. I cannot remember all the details of my post, so I can't help you. I'm sorry...
This issue is stale because it has been open 60 days with no activity. It will be closed in 30 days, but can be saved by removing the stale label or commenting.
Hi Biancode,
Closed because it was stale or did you manage to solve the problem?
Best regards,
Bert Kortenbach
from the stale state and we were waiting for the debug result before the Response-Filter, please ;)
(From my previous post)"Message.payload always is a zero length array instead of an array with actual values in it"
Maybe you can try it for yourself to see what is going on?
Modbus IO-File has to be improved and more documented for the next version v6.x - Release is planned to be on the roadmap for Node-RED 4.0 Q2-2023
Hi Biancode,
That's great! Thanks for picking this up!
This issue is stale because it has been open 60 days with no activity. It will be closed in 30 days, but can be saved by removing the stale label or commenting.