Node does not send an error message
DmitrySidorow opened this issue · 11 comments
Which node-red-contrib-modbus version are you using?
5.24.0
What happened?
The function of sending an empty error message no longer works.
Server
Modbus-Server Node
How can this be reproduced?
Use modbus flex write to unreachable tcp server
What did you expect to happen?
Node should send empty message if connection error. It helped me to keep track of communication with devices
Other Information
No response
Hi @DmitrySidorow yes, the node has a new check for inactive connection. We can add to send out an empty message on each fail for input, but maybe it is in your case not an error from a failed Modbus function anymore.
check the new warnings of the nodes
Hi @DmitrySidorow yes, the node has a new check for inactive connection. We can add to send out an empty message on each fail for input, but maybe it is in your case not an error from a failed Modbus function anymore.
Yes, it is definitely necessary for the node to send some kind of error message so that this message can be processed. Thank you
If you are in trouble without an empty msg, then you send to early to the node and this is not to handle by the node. We have different interests and discussed the new behavior in a group and it makes more problems if you send way too early to the modbus nodes. To handle your case, which is another perspective, it needs a new option to separate it.
Maybe a modbus state node is here a better solution to be able for asking the client node about its state.
see #348 - it is a different meaning if the Modbus client could not send or fails or if a message is too early or in the wrong moment passed into to the node. To handle both situations it makes sense to get a new node to check if a used client is ready to accept msg. That is easier to handle in programming and the programmer knows exactly what to case is at the problem of a not to send msg. The empty msg will just be sent if the Modbus client has a problem or fails.
In the most support requests we analyzed now, that more than 80% of the problems are too early sends into the node, while Modbus is not ready to accept and send the msg objects. It is not clear, which impact the deny of msg objects since v5.24 has in a project that uses the queue intensive. It would be great to learn more from the community about the needs in the different cases of the client and the nodes to handle the Modbus msg objects well.
This issue is stale because it has been open 60 days with no activity. It will be closed in 30 days, but can be saved by removing the stale label or commenting.