Modbus Flex Sequencer broken in 5.26?

[hoegge]

Which node-red-contrib-modbus version are you using?

5.26 - newest in node-red pallete

What happened?

After upgrading from 5.23 all my Modbus flows has stopped. Nothing gets through the Mobus Flex Sequencer It simply does nothing. The Modbus Flex Getter works fine.

It seems after a lot of troubleshooting, that the Flex Sequencer only fires if msg.payload contains something? Otherwise it ignores input.

Much slower too

Furthermore 5.26 is MUCH slower reading data using the sequencer - around a factor 5-10 compared to version 5.23. Speed instantly increased again going back to 5.23.

Server

Other/External server

How can this be reproduced?

Use in in Node-red 3.0.2

What did you expect to happen?

No response

Other Information

No response

[hoegge]

It seems to have happened here: b7acd97
where this was introduced here: 758a3a5#r131145217

Seems to be a breaking change, since documentation does not require an msg.payload input but msg.messages

[grewek]

Hi @hoegge

Thank you for the report, i have looked at the first issues and it seems to me that this is intended behaviour as we do not want the node to work on an empty payload.