Bilal-io/Selenium-Screenshot-Script

Wrong comment about cross platform

Eptick opened this issue · 1 comments

Eptick commented

You have a comment here

Selenium-Screenshot-Script/screenshot_headful_desktop.py

Line 1 in 2df2ce5

# This will work for any Desktop OS (Windows, MacOS, Linux Desktop)

That says that this will work on all system and it won't since you have hardcoded the path to the chromedriver here

Selenium-Screenshot-Script/screenshot_headful_desktop.py

Line 7 in 2df2ce5

with webdriver.Chrome("C:/chromedriver_win32/chromedriver") as driver:

People will get confused.

Bilal-io commented

Thank you @Eptick, you're right, fixed now.