Bill-Gray/PDCursesMod

terminfo addition

GitMensch opened this issue · 4 comments

GitMensch commented

This issue is about tracking the state of this. The "deletion commit" of 22c4d82 was reverted fully in PDCursesMod already, but the "addition" is not yet complete, more checks are needed for:

  • Makefiles: also install term.h?
  • Makefiles for several ports
  • framebuffer/DRM port, which didn't exist when the terminfo functions were removed or added
  • demos: add at least linking, ideally some using of those functions
  • cmake handling
  • docs

Originally posted by @GitMensch in #254 - related to #253

Bill-Gray commented

Inclusion in the framebuffer/DRM port was done as part of commit 2481460. The terminfo functions are linked into the PDCursesMod libraries on all platforms, so they are "at least link[ed]" to the demos. None are actually used, but what they would do in PDCursesMod is hard to see anyway; they're stubs.

It appears CMake handling occurred pretty much automatically. I briefly thought we might have to explicitly say that pdcurses/terminfo.c should be built, but a wildcard is used to ensure that any .c file in pdcurses is built.

Which leaves documentation. That was also handled (somewhat) automatically; when terminfo.c and term.h were restored to life, so was the "man" section of the first file. The next time docs/mkman.sh was run, the relevant documentation became part of docs/MANUAL.md.

So it looks to me as if the remaining four items can be checked off and this issue closed.

GitMensch commented

I think one thing still open:

  • demos: add at least linking, ideally some using of those functions
Bill-Gray commented

Well... the code is linked in (it's part of the library). It's not "used", but it's all stubs, so it wouldn't do anything anyway. I don't see much point in adding, say,

   int err_code = vid_attr( A_BLINK, 1, NULL);   /* does nothing */

to a demo.

GitMensch commented

Well... the code is linked in (it's part of the library).

Well, it wasn't, which was the reason for #253... If we don't have any demo (maybe one from ncurses?) then we don't know if cod with those functions would compile and link.

... but feel free to close the issue when you consider this "done".